{{ message }}
Support screen reader focus and activate on chat list rows#30769
Open
rezabakhshilaktasaraei wants to merge 2 commits into
Open
Support screen reader focus and activate on chat list rows#30769rezabakhshilaktasaraei wants to merge 2 commits into
rezabakhshilaktasaraei wants to merge 2 commits into
Conversation
2b236c9 to
750fe3e
Compare
750fe3e to
e792fcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat list rows are painted/virtual (no real
QWidget), so a screen reader couldn't move focus to a row or activate one. With the action interface from desktop-app/lib_ui#303, those requests now reachInnerWidget:accessibilityChildSetFocus, Activate →accessibilityChildActivate. Both hop to the main thread (UIA invokes actions on a background thread) and are dispatched by stable row identity (peer / entry / result pointer), so a reordered or replaced row is never acted on by mistake.SetFocusis honored directly — it is not gated on the screen-reader-mode detector, which can still be false during startup or for valid clients that aren't on its allowlist.selectChildByIndex(), which first clears secondary mouse hit-test state (hashtag delete, "more posts", chat-type filter, topic-jump, right button) so an Invoke can't trigger one of those instead of opening the row._skipTopDialogapplied — and the collapsed Archive row is exposed.Depends on desktop-app/lib_ui#303; CI won't compile until that is merged and the submodule updated.