{{ message }}
fix: truncate float literals to exact float64 precision#501
Merged
Conversation
The 45 statistical constants (Wichura 1988 probit function) had more significant digits than IEEE 754 float64 can represent, triggering oxlint no-loss-of-precision warnings. Replace each literal with its shortest exact float64 representation. No behavioral change — JS was already silently discarding the extra digits. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
gka
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary
src/lib/helpers/math.tsto their exact IEEE 754 float64 representationsString(Number(x))to find the shortest exact representation — all values are bit-for-bit identical at runtimeno-loss-of-precisionoxlint warningsTest plan
pnpm exec oxlint --type-aware— 0no-loss-of-precisionwarningspnpm test— 685/685 tests passpnpm check— 0 svelte-check errors🤖 Generated with Claude Code