{{ message }}
test: add unit tests for RegressionX/Y marks (#169)#378
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for svelteplot ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Prevents flaky jsdom "Cannot read properties of null" errors in canvas tests by awaiting Svelte's async reactive teardown and cancelling orphaned requestAnimationFrame callbacks in afterEach. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Added fix for the flaky jsdom What changed (
Verification: Full suite ( |
gka
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary
RegressionYmark covering linear/quadratic/loess regression types, confidence bands, grouping by stroke/z channels, custom CSS classes, and empty dataRegressionXmark covering axis swap (dependent=x → regression-y class), confidence bands, stroke grouping, and empty dataCloses #169
Test plan
npx vitest run src/tests/regressionY.test.svelte.ts— 10 tests passnpx vitest run src/tests/regressionX.test.svelte.ts— 4 tests passnpx vitest run— full suite passes (465 tests)npm run lint— clean🤖 Generated with Claude Code