{{ message }}
refactor: use slices.Backward to simplify the code#9501
Open
solunolab wants to merge 1 commit into
Open
Conversation
Signed-off-by: solunolab <solunolab@outlook.com>
Author
|
@roucc Hi, Could you please review this PR at your convenience? Thank you very much. |
ncw
requested changes
Jun 17, 2026
ncw
left a comment
ncw
left a comment
Member
There was a problem hiding this comment.
This looks fine. Can you remove the extra blank lines and I'll merge - thank you :-)
| for level := len(toDelete) - 1; level >= 0; level-- { | ||
| dirs := toDelete[level] | ||
| for level, dirs := range slices.Backward(toDelete) { | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
What is the purpose of this change?
There is a new function added in the go1.23 standard library, which can make the code more concise and easy to read.
More info can see golang/go#61899
Was the change discussed in an issue or in the forum before?
Checklist