{{ message }}
Allow setting headers, cookies, and session in WebSocket handshakes#14012
Draft
mkurz wants to merge 2 commits into
Draft
Allow setting headers, cookies, and session in WebSocket handshakes#14012mkurz wants to merge 2 commits into
mkurz wants to merge 2 commits into
Conversation
mkurz
changed the title
Allow accepted WebSocket handlers to attach response metadata to the opening handshake. The new Accepted value carries the selected subprotocol, response headers, and cookies alongside the message flow. Wire the metadata through the Scala and Java APIs and both server backends. Pekko HTTP appends headers to the upgrade response, while Netty uses a Play-specific handshaker factory so custom headers reach the actual WebSocket handshake. Document the new APIs and add integration coverage for custom handshake headers and cookies on both server backends.
Let accepted WebSocket handlers update the Play session during the opening handshake. Session data is baked with the configured session cookie baker, matching normal Result behavior. Expose the session helpers in Scala and Java, pass Java session data through the route adapter, and cover the emitted PLAY_SESSION cookie in the WebSocket integration tests.
mkurz
force-pushed
the
websocket-accepted-handshake-options
branch
from
2da613b to
8baa2db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
WIP WIP WIP WIP