I have the common problem that I have to silence phpstan errors with assert() usage because phpstan figures out that the assert will never fail. While that is not wrong, the assert is there to avoid any logic errors for future changes, and it also communicates to the developer of certain conditions that are supposed to be always true, so I don't mind it being redundant.

For example:

$foo = [];
// complex logic
// more complex logic
assert(count($foo) > 0); //  greater.alwaysTrue
// code expecting $foo to be non-empty

$foo = [];
// complex logic
// more complex logic
assert(array_key_exists('something', $foo)); // function.alreadyNarrowedType
// code expecting $foo to have that key

It's quite easy to put a "ignore-next-line" there, but usually it just means people will remove assert() calls, making the it easier for future code changes to introduce bugs.

I don't know a good solution there, except maybe have a config option to ignore certain types of errors for assert() specifically. And maybe I'm the only one being bothered by it :)

Either way, thanks for phpstan.