Skip to content

Fix strict mode in Docker by removing 0.0.0.0 warning#3784

Merged
lovelydinosaur merged 1 commit into
mkdocs:masterfrom
squidfunk:fix/docker-warning
Aug 23, 2024
Merged

Fix strict mode in Docker by removing 0.0.0.0 warning#3784
lovelydinosaur merged 1 commit into
mkdocs:masterfrom
squidfunk:fix/docker-warning

Conversation

@squidfunk

Copy link
Copy Markdown
Contributor

Fixes #3724 and #2108. Consensus for this change was reached in #3724 (comment)

I'd suggest we simply don't enforce the check against 0.0.0.0. (#2022)
Less config is better. Less code is better.

@lovelydinosaur lovelydinosaur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting the user here seems sensible, yep.

@pawamoy pawamoy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) No mention of this to remove from the docs?

@squidfunk

Copy link
Copy Markdown
Contributor Author

I searched for 0.0.0.0 but didn't find anything. I think since it's only a warning, the warning itself was not documented, and the general advise to not use the dev server for production would be, if mentioned in the docs, unaffected as it still holds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please allow running MkDocs with Docker and strict mode

3 participants