{{ message }}
SubConfig: allow to actually validate the nested configs#2807
Merged
Conversation
…e/2709_subconfig_fix
…n` constructor parameter to switch validation off (default, legacy) / on. Added a few tests.
…e/2709_subconfig_fix
smarie
changed the title
ignore_validation constructor parameter.
Contributor
Author
|
Note that another way to fix this would be to make subconfig strict by default, but toggle the "non-strict" flag in the default config schema for the "extra" option. As you prefer, just let me know |
This comment was marked as abuse.
This comment was marked as abuse.
oprypin
approved these changes
Aug 16, 2022
Contributor
Author
|
Thanks @oprypin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #2709
This is a fix for previous PR (reverted) #2710
SubConfignow has an optional constructor argument namedignore_validation. By default it isTrueto preserve retrocompatibility with legacy. Setting it toFalsewill now correctly collect and raise validation errors and warnings for subconfig items.