{{ message }}
Fully switch normal npm run compile to use tsgo too#321646
Merged
Merged
Conversation
We've had this enabled for watch for many months. Let's finish the move by switching this over now too Also gives a better name to the typecheck script
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the migration to tsgo for client type-checking by renaming the root typecheck script and updating developer/operator documentation and skills to reference the new script, while also wiring tsgo into the gulp compile pipeline.
Changes:
- Rename
compile-check-ts-nativetotypecheck-client(rootpackage.json) and update all references across docs/skills. - Update the gulp client
compileTaskto run an emit step plus a separatetsgono-emit typecheck. - Refresh agent-host Claude phase plans/smoke docs to use the new typecheck command.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/claude/smoke.md | Update prerequisite typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase9-plan.md | Update typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase8.5-plan.md | Update typecheck command references. |
| src/vs/platform/agentHost/node/claude/phase8-plan.md | Update typecheck command references. |
| src/vs/platform/agentHost/node/claude/phase7-plan.md | Update typecheck command references. |
| src/vs/platform/agentHost/node/claude/phase6.1-plan.md | Update typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase6-plan.md | Update checklist typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase5-plan.md | Update checklist typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase4-plan.md | Update checklist typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase13-plan.md | Update status/verification typecheck command references. |
| src/vs/platform/agentHost/node/claude/phase12-plan.md | Update validation/typecheck command references. |
| src/vs/platform/agentHost/node/claude/phase10.5-plan.md | Update verification typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase10-plan.md | Update verification typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase-plan.2.md | Update hygiene checklist typecheck command reference. |
| src/vs/platform/agentHost/node/claude/phase-plan.1.5.md | Update typecheck command reference. |
| src/vs/platform/agentHost/node/claude/CONTEXT.md | Update hygiene checklist typecheck command reference. |
| package.json | Rename compile-check-ts-native script to typecheck-client. |
| build/lib/compilation.ts | Adjust compile pipeline to emit + spawn tsgo no-emit typecheck. |
| .github/skills/sessions/SKILL.md | Update required compilation check command. |
| .github/skills/fix-ci-failures/SKILL.md | Update compilation verification command. |
| .github/skills/chat-customizations-editor/SKILL.md | Update typecheck command in validation snippet. |
| .github/skills/add-policy/SKILL.md | Update typecheck command in build verification snippet. |
| .github/copilot-instructions.md | Update documented typecheck command for src/-only changes. |
Copilot's findings
- Files reviewed: 23/23 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Yoyokrazy
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
We've had this enabled for watch for many months. Let's finish the move by switching this over now too
Also gives a better name to the typecheck script