Skip to content

Rspamd DKIM - improvements to default config and documentation#4653

Open
lukecyca wants to merge 6 commits into
docker-mailserver:masterfrom
lukecyca:rspamd-dkim-keys
Open

Rspamd DKIM - improvements to default config and documentation#4653
lukecyca wants to merge 6 commits into
docker-mailserver:masterfrom
lukecyca:rspamd-dkim-keys

Conversation

@lukecyca

@lukecyca lukecyca commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Description

  • Change the default dkim-signing.conf
    • support multiple domains with a single "path" line
    • support optional selector_map
  • Changes to setup config dkim (rspamd-dkim) to support the above
  • Refactor the rspamd DKIM documentation to simplify the common scenarios (multiple domains, single selector, migrating keys from opendkim)

Related issues:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary, I have added modified tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added information about changes made in this PR to CHANGELOG.md

@lukecyca

Copy link
Copy Markdown
Contributor Author

@polarathene any feedback on this? Would it help if I revised this in some way to incorporate some aspects of @GAS85's #4645 PR?

@polarathene

Copy link
Copy Markdown
Member

@polarathene any feedback on this?

Hey sorry I must have missed this (I get a lot of notifications).

I'm juggling quite a bit right now but at a quick glance this looks preferable to the other PR you referred to (I'm pretty sure I have feedback there where I expressed that PR would be fairly redundant for DMS to merge).

To review this I'll need to go over the prior discussions to refresh and be able to consider the changes (some which might require me to go over Rspamd docs on settings that have changed like try_fallback if those are missing context for their change).

One question I'd have from a quick look over is the docs advice change that referred to an RSA fallback, is that known to work with the selector map / path approach this PR switches over to? I know the existing one has a way to define multiple key types per domain (with the same or different selector IIRC).

Might need to verify if the RSA fallback works, so if you're able to look into that it'd be appreciated.


I should be able to make time for this PR sometime this month, and I think it looks like it will help progress towards the unified DKIM approach I'd like to get DMS to adopt, so thanks for taking the time to put this together ❤️

Presently when I can spare the time, I'll be first prioritizing a review on the Debian 13 Trixie upgrade PR as that's been quite a blocker for a while and needs my help/feedback, so I'll need to assist with getting that sorted.

I would still be interested in your PR being part of DMS v16 if all goes well after review 👍

@polarathene polarathene added this to the v16.0.0 milestone Feb 12, 2026
@github-actions github-actions Bot added the meta/stale This issue / PR has become stale and will be closed if there is no further activity label Mar 5, 2026
@docker-mailserver docker-mailserver deleted a comment from github-actions Bot Mar 5, 2026
@polarathene polarathene added stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI and removed meta/stale This issue / PR has become stale and will be closed if there is no further activity labels Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants