Repository navigation
Conversation
β¦k results The viewer API section told app authors to hand-roll the token handshake and said nothing about the client Deepnote hosts at /static/app-client/v1.js, which handles the token, polling, and read-only runs. apps.md now leads with that client and adds how an app gets notebook results: a JSON output with a schema, or a dataframe output, which holds one page of rows with the total in row_count and encodes values as described. The cloud app example now starts its runs with read-only project storage, as the guidance asks of clients that call the API directly.
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configuration
π Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. π WalkthroughWalkthroughThe local runner now sets Priority: β¬οΈ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Other Suggested reviewers: Merge Risk: βͺ Minimal Β· up to No specific breakage is established in the viewer example or notebook-output guidance, so there is no identified merge-blocking risk. π₯ Pre-merge checks | β 6β Passed checks (6 passed)
Warning Some tools did not complete. Review the errors below. π§ LanguageToolLanguageTool checks were skipped: reviews.tools.languagetool.enabled_only requires at least one selection in enabled_rules or enabled_categories. Select rules/categories, set enabled_only to false to use the default rules, or set enabled to false to disable LanguageTool. Comment |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #553 +/- ##
========================================
Coverage 90.00% 90.00%
========================================
Files 211 211
Lines 12451 12451
Branches 3588 3482 -106
========================================
Hits 11206 11206
Misses 1242 1242
Partials 3 3 β View full report in Codecov by Harness. π New features to boost your workflow:
|
The viewer API section of
apps.mdtold app authors to write the token handshake themselves. Deepnote hosts a browser client that does it, and no public doc mentioned the client or how an app gets notebook results into the page.apps.md, Add viewer API access: leads withhttps://deepnote.com/static/app-client/v1.jsandwindow.Deepnote.connect(). The handshake description stays for apps that call the API directly, which should now also senddetachedRunStorageMode: "readonly".apps.md, Return notebook results to an app (new):to_json, becauseto_dictsends"nan"and fails on missing timestampsblocks-code-and-sql.md: whatdeepnote_table_state.pageSizedoes.pnpm run lintAndFormat,pnpm typecheck,pnpm test(184 files, 3,368 tests), and cspell on the changed docs pass. The encoding statements were checked by running the toolkit's dataframe formatter and a real IPython kernel. The agent plugin counterpart is deepnote/agent-plugins#22.Summary by CodeRabbit
pageSizesetting, including its default and constraints.