{{ message }}
Fix specifications offset warnings and parameterize sendUsage#12619
Open
hardikkaurani wants to merge 2 commits into
Open
Fix specifications offset warnings and parameterize sendUsage#12619hardikkaurani wants to merge 2 commits into
hardikkaurani wants to merge 2 commits into
Conversation
Contributor
Greptile Summary
Confidence Score: 5/5The changes are narrowly scoped to null-safe specification handling and usage reporting parameter flow. No code issues were identified in the reviewed changes, and the implementation aligns computed resource limits with the usage telemetry path.
What T-Rex did
Reviews (2): Last reviewed commit: "Update build.cpus and build.memory spans..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12227
What does this PR do?
runtimeSpecificationandbuildSpecification) which could be null for existing or unmigrated resources.sendUsagein the Builds worker to receive dynamically adjusted memory and CPU limits instead of trying to look up the specifications statically.