Skip to content

Revert disable build cache#12612

Merged
TorstenDittmann merged 3 commits into
1.9.xfrom
revert/disable-build-cache
Jun 19, 2026
Merged

Revert disable build cache#12612
TorstenDittmann merged 3 commits into
1.9.xfrom
revert/disable-build-cache

Conversation

@TorstenDittmann

Copy link
Copy Markdown
Contributor

Summary

Tests

  • composer lint src/Appwrite/Platform/Modules/Functions/Workers/Builds.php

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

✨ Benchmark results

Comparing 1.9.x (before) to revert/disable-build-cache (after).

Before

Scenario P50 (ms) P95 (ms) Requests RPS
API total 12.84 130.93 185 35.52
Account 29.54 176.22 35 7.38
TablesDB 12.79 20.85 35 8.79
Storage 10.99 46.31 75 18.49
Functions 22.84 32.08 40 9.95

After

Scenario P50 (ms) P95 (ms) Requests RPS
API total 13.22 126.92 185 36.18
Account 28.64 166.92 35 7.5
TablesDB 12.57 18.11 35 9.12
Storage 11.34 47.18 75 19.14
Functions 20.91 28.72 40 10.33

Delta

Scenario P95 delta (ms)
API total -4.01
Account -9.29
TablesDB -2.74
Storage +0.87
Functions -3.36
Top API waits
API request Max wait (ms)
account.logs.list 508.93
account.sessions.email.create 166.75
account.password.update 158.07

@greptile-apps

greptile-apps Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Reverts #12602 by re-enabling the build cache: $cacheKey is restored in the coroutine's use clause and passed back to executor->createRuntime, and the executor image is bumped from 0.24.1 to 0.25.1 in both compose files to match.

  • Builds.php: $cacheKey was already defined in the enclosing scope at line 689 before the closure; restoring it to the use clause is correct.
  • docker-compose.yml / compose.phtml: Executor image version is consistently updated to 0.25.1 in both the main compose file and the install template.

Confidence Score: 5/5

Safe to merge — this is a clean revert that restores a previously working code path with a matching executor image bump.

The change is minimal and mechanically correct: $cacheKey is properly defined in the enclosing scope before the closure, the use clause correctly captures it by value, and it is passed to createRuntime as before. Both compose files are updated consistently to the same executor version. No logic has been introduced beyond restoring the prior state.

No files require special attention.

Important Files Changed

Filename Overview
src/Appwrite/Platform/Modules/Functions/Workers/Builds.php Restores $cacheKey in the coroutine's use clause and passes it to createRuntime; $cacheKey is properly defined in the enclosing scope at line 689 before the closure
docker-compose.yml Executor image bumped from openruntimes/executor:0.24.1 to 0.25.1 to match the reverted build-cache support
app/views/install/compose.phtml Same executor image bump (0.24.1 → 0.25.1) in the install compose template, consistent with docker-compose.yml

Reviews (2): Last reviewed commit: "fix: bump executor to 0.25.1" | Re-trigger Greptile

Comment thread src/Appwrite/Platform/Modules/Functions/Workers/Builds.php
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

🔄 PHP-Retry Summary

Flaky tests detected across commits:

Commit e09d0b0 - 1 flaky test
Test Retries Total Time Details
AuthMethodsIntegrationTest::testAuthMethodsIntegration 1 11.33s Logs

@TorstenDittmann TorstenDittmann merged commit 13058ab into 1.9.x Jun 19, 2026
46 checks passed
@TorstenDittmann TorstenDittmann deleted the revert/disable-build-cache branch June 19, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants