{{ message }}
Follow-up: land website review fixes#2
Draft
alrobles wants to merge 1 commit into
Draft
Conversation
Blocking fixes - Add img/favicon.ico (16x16, 32bpp, accent-green "A" mark) so the /img/favicon.ico link tags resolve. - Darken language badges for WCAG AA at 0.72rem: .lang.cpp #9b59b6 -> #7d3c98 (6.52:1 on light surface) .lang.r #3498db -> #1e6fb8 (4.82:1 on light surface) Add dark-mode overrides for both (#c39bdf, #74b6ec). - Always set data-theme on <html> in the inline boot script, computing from matchMedia when no saved value exists. Removes the first-paint icon flicker and lets the icon CSS collapse to two rules. Manual toggle behavior unchanged. Medium fixes - aria-pressed on the theme toggle, kept in sync with data-theme on init and on click. - Unify nav across pages: single "Projects" link to /projects/, "CV", theme toggle. Drops the confusing Projects/All projects split. - JSON-LD email: strip the mailto: prefix. - Add twitter:card meta to projects/index.html (homepage already had it; 404 stays noindex). - Static hardcoded year only; remove the JS overwrite + span#year on all three pages (no-JS users now see the same value as JS users). - Drop backdrop-filter on .site-header — solid bg avoids the cost and the partial-support gotchas. - Move the inline style on the projects-page lead paragraph into a .lead-muted class in the stylesheet. Other nits from the review - scroll-padding-top so in-page anchors clear the sticky header. - Dark-mode contrast: .social a:hover and .skip use var(--bg) for text instead of #fff on bright-green accent. - .lead text-align: left on mobile so the body copy doesn't go centered after the hero stacks. - Slightly bump dark-mode --border for the avatar/card edge. - Refine maxentcpp / softening copy to match upstream README (Rcpp-backed C++17 reimplementation; AI-assisted *development*, not workflows). Docs links verified: maxentcpp and sobol both publish genuine pkgdown reference sites, so "Docs" / "Documentation" labels stand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Summary
Follow-up to PR #1 with review fixes that landed on the branch after the original PR was merged.
Fixes
img/favicon.icoso favicon references no longer 404.data-themefrom saved preference or system preference.aria-pressedon theme toggles.twitter:cardon the projects page.Checks reported by implementation agent
<h1>per page./img/favicon.ico, return 200..lang.cpp6.52,.lang.r4.82 in light mode; 6.86 and 7.29 in dark mode.