{{ message }}
[agent_docker] add support for cgroups v2#1116
Open
anthonygego wants to merge 3 commits into
Open
Conversation
anthonygego
changed the title
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 medium |
🟢 Metrics 6 complexity · 2 duplication
Metric Results Complexity 6 Duplication 2
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
anthonygego
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR follows #1115 and adds full support for cgroups v2. It preserves the cgroups v1 support as this is still the default in some RHEL versions.
memory.oom.groupset to 1 to ensure all the container tasks are killed by the OOM killer once one it runs out of memory, since the OOM killer cannot be disabled anymore. This results in the container being killed by the system and INGInious checking if it died from OOM.memory.oom.groupflag to 1 for containers spawned by the Docker daemon.This full support for cgroups v2 allows to runs the code with rootless podman socket set as
DOCKER_HOST. Since podman does not support enumerating container runtimes from the API and that podman-py does not implement container attach yet, I suggest to keep Docker as the recommended runtime for now, yet I mention it is compatible in the doc.